frontend: fix tx details behaviour #3699
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonsirsha
force-pushed
the
frontend-fix-tx-details
branch
2 times, most recently
from
01d3b70 to
33cc544
Compare
1. Focus trap to include dialog's header for tx detail dialog. This way, the note input doesn't get auto focused. Also added autofocus inside FOCUSABLE_SELECTOR (useEsc hook) 2. Changed translations: Send to Sent, and Receive to Received
shonsirsha
force-pushed
the
frontend-fix-tx-details
branch
from
33cc544 to
68846a1
Compare
thisconnect
requested changes
Dec 3, 2025
Collaborator
thisconnect
left a comment
thisconnect
left a comment
There was a problem hiding this comment.
I haven't tested yet, but I think the FOCUSABLE_SELECTOR should be changed before doing any testing.
| textarea:not(:disabled), | ||
| [tabindex]:not([tabindex="-1"]):not(:disabled) | ||
| [tabindex]:not([tabindex="-1"]):not(:disabled), | ||
| [autofocus]:not(:disabled) |
Collaborator
There was a problem hiding this comment.
This would still get the first input element and focus it. I believe we want either:
- all elements that either have autofocus or tabindex != -1 regardless of the tagname
- or explicitly
a[tabindex]:not([tabindex="-1"]), button[autofocus]:not(:disabled), input[autofocus]:not(:disabled)...
| slim | ||
| medium> | ||
| medium | ||
| > |
| return t('generic.sent'); | ||
| case 'receive': | ||
| return t('generic.receiveWithoutCoinCode'); | ||
| return t('generic.received'); |
Collaborator
There was a problem hiding this comment.
Ideally this and the app.json change would be in a 2nd commit as it is unrelated to the focus fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dialog. This way, the note input doesn't get auto focused.
Also added autofocus inside FOCUSABLE_SELECTOR (useEsc hook)