frontend: improve BT alert message #3700
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonsirsha
force-pushed
the
frontend-improve-alert-message
branch
3 times, most recently
from
168ad88 to
726901c
Compare
shonsirsha
changed the title
shonsirsha
changed the title
shonsirsha
force-pushed
the
frontend-improve-alert-message
branch
2 times, most recently
from
3b9c913 to
f426d75
Compare
On iOS, Bluetooth can be “off” for two different reasons: 1. System Bluetooth is turned off 2. Bluetooth permission is disabled specifically for BitBoxApp This commit adds logic to distinguish between these cases and shows the appropriate message for each.
shonsirsha
force-pushed
the
frontend-improve-alert-message
branch
from
f426d75 to
c5fb98a
Compare
benma
reviewed
Dec 4, 2025
Contributor
benma
left a comment
benma
left a comment
There was a problem hiding this comment.
Looks nice, but I still need to test.
| "title": "Welcome" | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
make locize-fix should add a newline at the end. If not, update locize cli, there was a change in some recent version.
| {t('bluetooth.disabledPermissionDescription')} | ||
| </span> | ||
| <A className={styles.link} href="app-settings:"> | ||
| Enable |
Contributor
There was a problem hiding this comment.
localize this? maybe there is already a key that has this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS, Bluetooth can be “off” for two different reasons:
System Bluetooth is turned off
Bluetooth permission is disabled specifically for BitBoxApp
This commit adds logic to distinguish between these cases and
shows the appropriate message for each.
If system bluetooth is turned off:
If bluetooth permission is disabled specifically for BBApp:
On clicking "Enable", user will be brought to the Application settings:
