api/firmware: prevent sleep on macOS during long running queries #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing long interactions on the device, e.g. recovering from 24 words, and macOS goes to sleep, USB interaction would be slowed down and the workflow would be aborted. This commit prevents this from happening by preventing macOS from going to sleep during such an interaction. The alternative was to expose callbacks here and let the BitBoxApp (and other users) implement the callbacks, but it seems like every app that uses this lib would want this. In case not, we add a build flag if not desired.
|
@thisconnect you can test by setting the screensaver time to 1min in the macOS settings under "Lock screen", then running for example
|
thisconnect
approved these changes
Sep 19, 2024
benma
added a commit
to benma/bitbox-wallet-app
that referenced
this pull request
Sep 19, 2024
To prevent USB communication interruptions when e.g. recovering from 24 words. See BitBoxSwiss/bitbox02-api-go#111 ``` go get github.com/BitBoxSwiss/bitbox02-api-go@88d5934 go mod tidy go mod vendor ```
benma
added a commit
to benma/bitbox-wallet-app
that referenced
this pull request
Sep 24, 2024
To prevent USB communication interruptions when e.g. recovering from 24 words. See BitBoxSwiss/bitbox02-api-go#111 ``` go get github.com/BitBoxSwiss/bitbox02-api-go@b5eea13 go mod tidy go mod vendor ```
benma
added a commit
to benma/bitbox-wallet-app
that referenced
this pull request
Sep 25, 2024
To prevent USB communication interruptions when e.g. recovering from 24 words. See BitBoxSwiss/bitbox02-api-go#111 ``` go get github.com/BitBoxSwiss/bitbox02-api-go@a2115fe go mod tidy go mod vendor ```
benma
added a commit
to benma/bitbox-wallet-app
that referenced
this pull request
Sep 25, 2024
To prevent USB communication interruptions when e.g. recovering from 24 words. See BitBoxSwiss/bitbox02-api-go#111 ``` go get github.com/BitBoxSwiss/bitbox02-api-go@a2115fe go mod tidy go mod vendor ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing long interactions on the device, e.g. recovering from 24 words, and macOS goes to sleep, USB interaction would be slowed down and the workflow would be aborted.
This commit prevents this from happening by preventing macOS from going to sleep during such an interaction.
The alternative was to expose callbacks here and let the BitBoxApp (and other users) implement the callbacks, but it seems like every app that uses this lib would want this. In case not, we add a build flag if not desired.