Send to self #118
Merged
Send to self #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be used to check if e.g. the firmware displays the expected confirmations to the user. Similar to BitBoxSwiss/bitbox-wallet-app@e2ef679.
Can only make use of it starting v9.22.0. The .proto messages have been pulled from https://github.com/BitBoxSwiss/bitbox02-firmware/tree/c35647384740683ab06309ff34b3395d5c026d58/messages and the .pb.go files generated from it according to this repo's README instructions. When sending coins to an address of the same keystore, but different account, you can provide the script config of the other account in the `outputScriptConfigs` and link the output to it.
Marked the wrong one as the simulator test.
Previous commit pulled in the new firmware protobuf messages, so we can add a test for it now.
Beerosagos
approved these changes
Feb 25, 2025
| @@ -614,6 +617,7 @@ func TestSimulatorBTCSignSilentPayment(t *testing.T) { | |||
| Keypath: accountKeypath, | |||
| }, | |||
| }, | |||
| nil, | |||
There was a problem hiding this comment.
nit (here and in some other file too): The BTCSign func signature will only be changed in the next commit. Probably it isn't worth the time needed to fix, tho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.