Skip to content

Commit

Permalink
Dockerfile: Use python3 executable.
Browse files Browse the repository at this point in the history
Python should be invoked as `python3` since we are writing python3 code
and not python2. See https://peps.python.org/pep-0394/#recommendation
Many (most?) distributions do not distribute a "python" executable any
more, forcing you to pick either 2 or 3.
  • Loading branch information
NickeZ committed Aug 23, 2024
1 parent 73aa02f commit fc0515b
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .containerversion
Original file line number Diff line number Diff line change
@@ -1 +1 @@
42
43
3 changes: 0 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,6 @@ RUN if [ "${TARGETPLATFORM}" = "linux/arm64" ]; then \
rm /tmp/protoc-21.2.zip
ENV PATH /opt/protoc/bin:$PATH

# Make Python3 the default
RUN update-alternatives --install /usr/bin/python python /usr/bin/python3 1

# Developer tools
RUN apt-get update && apt-get install -y \
bash-completion
Expand Down
1 change: 1 addition & 0 deletions external/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ ExternalProject_Add(libwally-core
COMMAND ${CMAKE_COMMAND} -E env
"CFLAGS=${LIBWALLY_CFLAGS}"
"LDFLAGS=${LIBWALLY_LDFLAGS}"
PYTHON_VERSION=3
${CMAKE_CURRENT_SOURCE_DIR}/libwally-core/configure
${CONFIGURE_FLAGS}
${LIBWALLY_CONFIGURE_FLAGS}
Expand Down
2 changes: 1 addition & 1 deletion scripts/expand_template
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/env python
#!/usr/bin/env python3
"""Expand python templates"""

from string import Template
Expand Down
2 changes: 1 addition & 1 deletion scripts/get_version
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/env python
#!/usr/bin/env python3
"""
Parse the tags and strip the prefix
First argument should be prefix to match against
Expand Down

0 comments on commit fc0515b

Please sign in to comment.