Allow cmake to find gcc with env variable #1272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows cmake to find gcc even on macOS ARM where homebrew install folder is different. By setting an enviromental variable and then fetching it arm.cmake file. If the value is not set it defaults to previous value. Signed-off-by: RostarMarek <rostarmarek@gmail.com>
NickeZ
requested changes
Aug 18, 2024
| @@ -1,10 +1,14 @@ | |||
| set(CMAKE_SYSTEM_NAME "Generic") | |||
| set(CMAKE_SYSTEM_PROCESSOR "arm") | |||
|
|
|||
| set(LOCATION_PATH $ENV{HOMEBREW_PATH}) | |||
There was a problem hiding this comment.
I'm not a big fan of HOMEBREW_PATH in the arm.cmake file. What do you think about calling it ARMROOT or GCCROOT or something similar?
There was a problem hiding this comment.
Sure as mentioned in the opening comment, I do not expect this to get merged, just wanted to suggest a fix to a issue i found.
Thompson1985
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows cmake to find gcc even on macOS ARM where homebrew install folder is different. By setting an enviromental variable and then fetching it arm.cmake file. If the value is not set it defaults to previous value.
I know there are probably more changes needed for local environment development on macOS ARM, but I found this fix fairly easy to do and not intrusive to previous builds so I wanted to share it this way.
I do not expect this to be merged, but based on our previous discussion I decided that this would be fairly striaghtforward way to share this.