-
Notifications
You must be signed in to change notification settings - Fork 299
feat(sdk-coin-canton): added transaction class and local parser for prepared transaction data #7159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c2e5729
to
f0cd4f6
Compare
beeed3a
to
b6a59d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds transaction classes and local parser functionality for Canton prepared transaction data. It enables the SDK to parse raw Canton transaction data and extract key information like sender, receiver, and amounts from protobuf-encoded prepared transactions.
- Adds a new Transaction class for handling Canton prepared transaction data with parsing capabilities
- Implements a utils method to parse raw Canton transaction data and extract transaction details
- Adds a separate WalletInitialization Transaction class for wallet initialization scenarios
Reviewed Changes
Copilot reviewed 23 out of 25 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
tsconfig.json | Includes resources directory for protobuf files |
utils.ts | Adds parseRawCantonTransactionData method for transaction parsing |
transaction.ts | Implements Transaction class with prepared transaction handling |
iface.ts | Defines interfaces for transaction data and protobuf structures |
package.json | Adds protobuf-ts/runtime dependency and updates build scripts |
resources/ | Contains protobuf message type definitions for Canton transaction parsing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
modules/sdk-coin-canton/src/lib/walletInitialization/transaction.ts
Outdated
Show resolved
Hide resolved
…tion local parser Ticket: COIN-5871
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Ticket: COIN-5871