Skip to content

Conversation

@OttoAllmendinger
Copy link
Contributor

This PR enhances the wasm-utxo package with several code quality improvements:

  • Add proper describe blocks to organize test cases into suites
  • Remove unused code and variables throughout test files
  • Add ESLint configuration for TypeScript code linting
  • Add linting step to CI workflow for early issue detection
  • Improve type safety with explicit type assertions and proper type handling

These changes help with test organization, make output more readable, and
enhance the overall code quality by enforcing better practices through
automated tooling.

Issue: BTC-2786

OttoAllmendinger and others added 5 commits November 24, 2025 09:47
Add proper describe blocks to organize test cases into suites for better
test hierarchy and reporting. This change helps with test organization
and makes output more readable.

Issue: BTC-2786

Co-authored-by: llm-git <llm-git@ttll.de>
Clean up test files by removing unused functions, parameters and types.
Add TypeScript compiler options to detect and prevent unused code.

Issue: BTC-2786

Co-authored-by: llm-git <llm-git@ttll.de>
Added ESLint dependencies and configuration for TypeScript code linting.
Created an initial eslint.config.js with recommended settings and appropriate
ignore patterns for the project structure.

Issue: BTC-2786

Co-authored-by: llm-git <llm-git@ttll.de>
Improve type safety by adding explicit type assertions and proper type
handling for node and object structures. This fixes potential TypeScript
errors with JSON stringification of nodes, unknown types, and array
indexing. Also improves error message display by properly serializing
objects to strings.

Issue: BTC-2786

Co-authored-by: llm-git <llm-git@ttll.de>
Add ESLint check in GitHub Actions CI workflow for the wasm-utxo package.
Runs between formatting checks and tests to catch potential issues early.

Issue: BTC-2786

Co-authored-by: llm-git <llm-git@ttll.de>
@OttoAllmendinger OttoAllmendinger marked this pull request as ready for review November 24, 2025 09:07
@OttoAllmendinger OttoAllmendinger requested a review from a team as a code owner November 24, 2025 09:07
@OttoAllmendinger OttoAllmendinger merged commit bd07bb2 into master Nov 24, 2025
1 check passed
@OttoAllmendinger OttoAllmendinger deleted the BTC-2786.eslint branch November 24, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants