Skip to content

Conversation

@youngjungithub
Copy link
Contributor

@youngjungithub youngjungithub commented Mar 4, 2025

No description provided.

@youngjungithub youngjungithub requested a review from a team as a code owner March 4, 2025 17:12
@youngjungithub youngjungithub marked this pull request as draft March 4, 2025 17:13
@youngjungithub youngjungithub self-assigned this Mar 4, 2025
@youngjungithub youngjungithub marked this pull request as ready for review March 4, 2025 18:34
@youngjungithub youngjungithub marked this pull request as draft March 5, 2025 15:37
@youngjungithub youngjungithub marked this pull request as ready for review March 5, 2025 17:27
Copy link
Contributor

@ericcrosson-bitgo ericcrosson-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @youngjungithub!

Will you please squash the commits on this PR into just one commit? This helps create a more organized git history

Comment on lines -218 to -219
{ type: 'string', format: 'number' },
{ type: 'string', enum: ['true', 'false'] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: it's really interesting that the order of these array elements swapped 🤔 It seems deterministic, and it is alphabetical too I suppose

chore: fix error

chore: fix error

chore: fix error

chore: remove comments

chore: revert changes

fix: approach

fix: bug
@youngjungithub
Copy link
Contributor Author

Great work, @youngjungithub!

Will you please squash the commits on this PR into just one commit? This helps create a more organized git history

It's done!

@ericcrosson-bitgo ericcrosson-bitgo merged commit 3359aeb into master Mar 5, 2025
6 checks passed
@ericcrosson-bitgo ericcrosson-bitgo deleted the openapi branch March 5, 2025 19:30
@github-actions
Copy link

github-actions bot commented Mar 5, 2025

🎉 This PR is included in version @api-ts/openapi-generator@5.7.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version @api-ts/typed-express-router@2.0.0-beta.1 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version @api-ts/express-wrapper@2.0.0-beta.1 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version @api-ts/typed-express-router@1.1.14 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version @api-ts/express-wrapper@1.0.34 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version @api-ts/superagent-wrapper@1.3.4 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants