Update to support pubKeyHash and scriptHash for zcash forks #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OttoAllmendinger
requested changes
May 24, 2024
| "name": "@bitgo-forks/ecpair", | ||
| "version": "0.0.0-semantic-release-managed", | ||
| "description": "Fork of ecpair with BitGo specific changes", | ||
| "name": "@runonflux/bitgo-ecpair", |
There was a problem hiding this comment.
did you push to the wrong remote by any chance?
|
sorry, this change is not useful for the BitGo stack |
|
Yes sorry about this. I made a mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating Zcash ECPAIR from WIF and passing network options, a typeforce check will fail.
Reason
Because Zcash and some forks based on it have pubKeyHash and scriptHash bigger than UInt8
These two values don't appear to be used in this library.