Port-SpecialDirectoryUtilities #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a test report for SystemPathUtilities such that Emscripten properly reports the tests were skipped. Added SpecialDirectoryUtilities in their basic form and tests to go with them.
MakoEnergy
added
enhancement
Skip some tests on Emscripten. Don't always add a slash to the directory. Attempt to see if 'nix can benefit from debugtests.
Abolished the old lambda that would write to a file and then load it to get the console output and instead now use the new RunCommand available in Mezz_Test. Updated the Jagati version used to 30.2. Removed debugtests from the JenkinsFile.
Updated symlinks on windows to invoke the system specific function the same way. Moved the heavy file creation tests to be an isolated test group. Updated some invocations of "RunCommand" to be "RunCommandInShell" instead.
Windows has some serious issues with file and directory removals when they happen rapidly, seemingly in the same folder in two threads, or just in general. There seem to be a few causes, but primarily that windows will lock a file preventing its removal if it is loaded by a program. Sometimes this can happen from the intended calling application, or even just an anti-virus. So there isn't actually a 100% reliable way to delete a file without multiple retries on windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit with some fixes and new functionality.
Fixed a test report for SystemPathUtilities such that Emscripten properly reports the tests were skipped. Added SpecialDirectoryUtilities in their basic form and tests to go with them.