Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FLK-E722) Do not use bare except, specify exception instead #168

Open
kgashok opened this issue Jan 2, 2022 · 4 comments
Open

(FLK-E722) Do not use bare except, specify exception instead #168

kgashok opened this issue Jan 2, 2022 · 4 comments
Assignees
@Professor-Sathish
Labels
good first issue An issue to get started with for contributors

Comments

@kgashok
Copy link
Collaborator

kgashok commented Jan 2, 2022

Description

Using except without a specific exception can be error prone.

Occurrences

There are 2 occurrences of this issue in the repository.

Line 123 and Line 142.
@kgashok kgashok added the good first issue An issue to get started with for contributors label Jan 2, 2022
@kgashok kgashok changed the title (FLK-E722) Do not use bare except, specify exception instead #15 (FLK-E722) Do not use bare except, specify exception instead Jan 2, 2022
@h-leth h-leth mentioned this issue Jan 2, 2022
Closed
@Professor-Sathish
Copy link
Contributor

I want to solve this issue. Can you assign me?

@kgashok
Copy link
Collaborator Author

kgashok commented Jan 3, 2022 •
edited
Loading

@Professor-Sathish It is all yours.

@kgashok
Copy link
Collaborator Author

kgashok commented Jan 6, 2022

Discuss with @Pavithratrdev - she knows how Exceptions are handled in the real world.

Pavithratrdev pushed a commit to Pavithratrdev/saythanks.io that referenced this issue Jan 7, 2022
@Pavithratr1603
Displayed the exact exception - Fixed - BlitzKraft#168
1c71f01
@Pavithratrdev Pavithratrdev mentioned this issue Jan 7, 2022
Merged
Professor-Sathish added a commit to Professor-Sathish/saythanks.io that referenced this issue Jan 9, 2022
@Professor-Sathish
Update storage.py
1c49ef5 
fixed BlitzKraft#168
@Professor-Sathish Professor-Sathish mentioned this issue Jan 9, 2022
Closed
1 task
Professor-Sathish added a commit to Professor-Sathish/saythanks.io that referenced this issue Jan 9, 2022
@Professor-Sathish
Update storage.py
8555a2d 
fixed BlitzKraft#168
Pavithratrdev pushed a commit to Pavithratrdev/saythanks.io that referenced this issue Jan 17, 2022
@Pavithratr1603
Exception Handled. Fixed - BlitzKraft#168
6524535
@tushar5526
Copy link
Contributor

I think we can close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Professor-Sathish Professor-Sathish

Labels
good first issue An issue to get started with for contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changed from except: to else:
Update storage.py Professor-Sathish/saythanks.io
3 participants
@kgashok @tushar5526 @Professor-Sathish