Skip to content

Be more consistent with datatype for ability_id fields. #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eminence wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Be more consistent with datatype for ability_id fields. #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion s2clientprotocol/common.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ syntax = "proto2";
package SC2APIProtocol;

message AvailableAbility {
optional int32 ability_id = 1;
optional uint32 ability_id = 1;
optional bool requires_point = 2;
}

Expand Down
2 changes: 1 addition & 1 deletion s2clientprotocol/query.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ message ResponseQueryAvailableAbilities {

//--------------------------------------------------------------------------------------------------
message RequestQueryBuildingPlacement {
optional int32 ability_id = 1;
optional uint32 ability_id = 1;
optional Point2D target_pos = 2;
optional uint64 placing_unit_tag = 3; // Not required
}
Expand Down
4 changes: 2 additions & 2 deletions s2clientprotocol/raw.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ message ActionRaw {
}

message ActionRawUnitCommand {
optional int32 ability_id = 1;
optional uint32 ability_id = 1;
oneof target {
Point2D target_world_space_pos = 2;
uint64 target_unit_tag = 3;
Expand All @@ -172,6 +172,6 @@ message ActionRawCameraMove {
}

message ActionRawToggleAutocast {
optional int32 ability_id = 1;
optional uint32 ability_id = 1;
repeated uint64 unit_tags = 2;
}
2 changes: 1 addition & 1 deletion s2clientprotocol/spatial.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ message ActionSpatial {
}

message ActionSpatialUnitCommand {
optional int32 ability_id = 1;
optional uint32 ability_id = 1;
oneof target {
PointI target_screen_coord = 2;
PointI target_minimap_coord = 3;
Expand Down
2 changes: 1 addition & 1 deletion s2clientprotocol/ui.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,5 +127,5 @@ message ActionProductionPanelRemoveFromQueue {
}

message ActionToggleAutocast {
optional int32 ability_id = 1;
optional uint32 ability_id = 1;
}