Skip to content

Merge branch 'generic-object-layer' of github.com:BlockProject3D/rege… #10

Merge branch 'generic-object-layer' of github.com:BlockProject3D/rege…

Merge branch 'generic-object-layer' of github.com:BlockProject3D/rege… #10

GitHub Actions / clippy succeeded May 22, 2024 in 1s

clippy

78 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 78
Note 0
Help 0

Versions

  • rustc 1.78.0 (9b00956e5 2024-04-29)
  • cargo 1.78.0 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (9b00956 2024-04-29)

Annotations

Check warning on line 162 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
   --> testprog/src/main.rs:162:9
    |
162 |         return MySystem { val: 0 };
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
162 -         return MySystem { val: 0 };
162 +         MySystem { val: 0 }
    |

Check warning on line 128 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
   --> testprog/src/main.rs:126:13
    |
126 | /             return ComplexSystem {
127 | |                 events: Vec::with_capacity(5),
128 | |             };
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
126 ~             ComplexSystem {
127 +                 events: Vec::with_capacity(5),
128 ~             }
    |

Check warning on line 94 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
  --> testprog/src/main.rs:90:13
   |
90 | /             return ComplexComponent {
91 | |                 last_order: 0,
92 | |                 order,
93 | |                 value,
94 | |             };
   | |_____________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
   = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
   |
90 ~             ComplexComponent {
91 +                 last_order: 0,
92 +                 order,
93 +                 value,
94 ~             }
   |

Check warning on line 187 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `my2` is never read

warning: field `my2` is never read
   --> testprog/src/main.rs:187:5
    |
184 | pub struct TestSystemManager {
    |            ----------------- field in this struct
...
187 |     my2: MySystem2,
    |     ^^^
    |
    = note: `#[warn(dead_code)]` on by default

Check warning on line 240 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `state`

warning: unused variable: `state`
   --> testprog/src/main.rs:240:45
    |
240 |     fn on_update(&mut self, ctx: &mut Ctx1, state: &i32) {
    |                                             ^^^^^ help: if this is intentional, prefix it with an underscore: `_state`

Check warning on line 240 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `ctx`

warning: unused variable: `ctx`
   --> testprog/src/main.rs:240:29
    |
240 |     fn on_update(&mut self, ctx: &mut Ctx1, state: &i32) {
    |                             ^^^ help: if this is intentional, prefix it with an underscore: `_ctx`

Check warning on line 236 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `state`

warning: unused variable: `state`
   --> testprog/src/main.rs:236:45
    |
236 |     fn on_remove(&mut self, ctx: &mut Ctx1, state: &i32) {
    |                                             ^^^^^ help: if this is intentional, prefix it with an underscore: `_state`

Check warning on line 236 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `ctx`

warning: unused variable: `ctx`
   --> testprog/src/main.rs:236:29
    |
236 |     fn on_remove(&mut self, ctx: &mut Ctx1, state: &i32) {
    |                             ^^^ help: if this is intentional, prefix it with an underscore: `_ctx`

Check warning on line 232 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `event`

warning: unused variable: `event`
   --> testprog/src/main.rs:232:57
    |
232 |     fn on_event(&mut self, ctx: &mut Ctx1, state: &i32, event: &Event<()>) {
    |                                                         ^^^^^ help: if this is intentional, prefix it with an underscore: `_event`

Check warning on line 232 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `state`

warning: unused variable: `state`
   --> testprog/src/main.rs:232:44
    |
232 |     fn on_event(&mut self, ctx: &mut Ctx1, state: &i32, event: &Event<()>) {
    |                                            ^^^^^ help: if this is intentional, prefix it with an underscore: `_state`

Check warning on line 232 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `ctx`

warning: unused variable: `ctx`
   --> testprog/src/main.rs:232:28
    |
232 |     fn on_event(&mut self, ctx: &mut Ctx1, state: &i32, event: &Event<()>) {
    |                            ^^^ help: if this is intentional, prefix it with an underscore: `_ctx`

Check warning on line 207 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `state`

warning: unused variable: `state`
   --> testprog/src/main.rs:207:45
    |
207 |     fn on_update(&mut self, ctx: &mut Ctx1, state: &i32) {
    |                                             ^^^^^ help: if this is intentional, prefix it with an underscore: `_state`

Check warning on line 207 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `ctx`

warning: unused variable: `ctx`
   --> testprog/src/main.rs:207:29
    |
207 |     fn on_update(&mut self, ctx: &mut Ctx1, state: &i32) {
    |                             ^^^ help: if this is intentional, prefix it with an underscore: `_ctx`

Check warning on line 203 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `state`

warning: unused variable: `state`
   --> testprog/src/main.rs:203:45
    |
203 |     fn on_remove(&mut self, ctx: &mut Ctx1, state: &i32) {
    |                                             ^^^^^ help: if this is intentional, prefix it with an underscore: `_state`

Check warning on line 203 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `ctx`

warning: unused variable: `ctx`
   --> testprog/src/main.rs:203:29
    |
203 |     fn on_remove(&mut self, ctx: &mut Ctx1, state: &i32) {
    |                             ^^^ help: if this is intentional, prefix it with an underscore: `_ctx`

Check warning on line 199 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `event`

warning: unused variable: `event`
   --> testprog/src/main.rs:199:57
    |
199 |     fn on_event(&mut self, ctx: &mut Ctx1, state: &i32, event: &Event<()>) {
    |                                                         ^^^^^ help: if this is intentional, prefix it with an underscore: `_event`

Check warning on line 199 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `state`

warning: unused variable: `state`
   --> testprog/src/main.rs:199:44
    |
199 |     fn on_event(&mut self, ctx: &mut Ctx1, state: &i32, event: &Event<()>) {
    |                                            ^^^^^ help: if this is intentional, prefix it with an underscore: `_state`

Check warning on line 199 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `ctx`

warning: unused variable: `ctx`
   --> testprog/src/main.rs:199:28
    |
199 |     fn on_event(&mut self, ctx: &mut Ctx1, state: &i32, event: &Event<()>) {
    |                            ^^^ help: if this is intentional, prefix it with an underscore: `_ctx`
    |
    = note: `#[warn(unused_variables)]` on by default

Check warning on line 36 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `Context`

warning: unused import: `Context`
  --> testprog/src/main.rs:36:22
   |
36 | use regecs::system::{Context as _, Update};
   |                      ^^^^^^^

Check warning on line 30 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `regecs::component::list::List`

warning: unused import: `regecs::component::list::List`
  --> testprog/src/main.rs:30:5
   |
30 | use regecs::component::list::List;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 221 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `regecs_codegen::Object`

warning: unused import: `regecs_codegen::Object`
   --> testprog/src/main.rs:221:5
    |
221 | use regecs_codegen::Object;
    |     ^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 220 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `regecs_codegen::New`

warning: unused import: `regecs_codegen::New`
   --> testprog/src/main.rs:220:5
    |
220 | use regecs_codegen::New;
    |     ^^^^^^^^^^^^^^^^^^^

Check warning on line 213 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary parentheses around type

warning: unnecessary parentheses around type
   --> testprog/src/main.rs:213:22
    |
213 |     type Arguments = (i32);
    |                      ^   ^
    |
    = note: `#[warn(unused_parens)]` on by default
help: remove these parentheses
    |
213 -     type Arguments = (i32);
213 +     type Arguments = i32;
    |

Check warning on line 33 in testprog/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `Context as _`

warning: unused import: `Context as _`
  --> testprog/src/main.rs:33:29
   |
33 | use regecs::object::{Class, Context as _, Object, ObjectRef};
   |                             ^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

Check warning on line 176 in codegen/src/new_impl/build_arguments.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> codegen/src/new_impl/build_arguments.rs:176:59
    |
176 |                 TraitBody::from_enum(items, name.clone(), &ctx)
    |                                                           ^^^^ help: change this to: `ctx`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default