Rhino compatibility

[chenkasirer]

Some minor changes related to Rhino/Ironpython compatibility.

• Added Rhino install plugin
• Inserted numpy imports into the methods where they are called
• Added PlateElement and PlateFeature to second level imports

What type of change is this?

• Bug fix in a backwards-compatible manner.
• New feature in a backwards-compatible manner.
• Breaking change: bug fix or new feature that involve incompatible API changes.
• Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
• I ran all tests on my computer and it's all green (i.e. invoke test).
• I ran lint on my computer and there are no errors (i.e. invoke lint).
• I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
• I have added tests that prove my fix is effective or that my feature works.
• I have added necessary documentation (if appropriate)

[petrasvestartas]

I reviewed the commits. I think, it can be merged.

I would maybe just keep model.print(), instead of model.print_model()

Or, if we specify the type of print, then it would be good to have print_hierarchy(), print_interactions() that refers to a) whole model, b) tree, c) graph. But I think you most often want to do this: model.print() or print(model) in the shortest way possible.

[chenkasirer]

I reviewed the commits. I think, it can be merged.

I would maybe just keep model.print(), instead of model.print_model()

Or, if we specify the type of print, then it would be good to have print_hierarchy(), print_interactions() that refers to a) whole model, b) tree, c) graph. But I think you most often want to do this: model.print() or print(model) in the shortest way possible.

Hey @petrasvestartas!

Thanks for reviewing. The print methods I changed because IronPython for some reason won't let you define a method called print not sure why:

IronPython 2.7.8 (2.7.8.0) on .NET 4.0.30319.42000 (64-bit)
Type "help", "copyright", "credits" or "license" for more information.
>>> def print():
  File "<stdin>", line 1
    def print():
        ^
SyntaxError: unexpected token 'print'

[chenkasirer]

I reviewed the commits. I think, it can be merged.
I would maybe just keep model.print(), instead of model.print_model()
Or, if we specify the type of print, then it would be good to have print_hierarchy(), print_interactions() that refers to a) whole model, b) tree, c) graph. But I think you most often want to do this: model.print() or print(model) in the shortest way possible.

Hey @petrasvestartas!

Thanks for reviewing. The print methods I changed because IronPython for some reason won't let you define a method called print not sure why:

IronPython 2.7.8 (2.7.8.0) on .NET 4.0.30319.42000 (64-bit)
Type "help", "copyright", "credits" or "license" for more information.
>>> def print():
  File "<stdin>", line 1
    def print():
        ^
SyntaxError: unexpected token 'print'

Asked ChatGPT which reminded me that in Python 2.x print is a language token, not just a function. So I guess that's why..

[tomvanmele]

perhaps we should just switch to using __str__ and print with print(model)

[chenkasirer]

sounds good to me but would have to make changes in Tree.print_hierarchy and InteractionGraph.print_interactions as they internally call print

[chenkasirer]

btw I think we should generally avoid calls to print in COMPAS, especially the parts that are more library-ish.

[petrasvestartas]

Let's change to __str__ and then additional change will be needed for the tree in compas and merge this pull request. Due to multiple other packages, still ironpython needs to be supported for some time.

[chenkasirer]

@tomvanmele changed prints to __str__. This relies on the changes by @Licini in compas-dev/compas#1314.

[tomvanmele]

i dont' think this makes sense.InteractionGraph.interactions should not return a string, but rather a list of interactions.

[chenkasirer]

agree that's weird, but this previously did the same just using print. I renamed this to interactions_str as it really just builds a string form of the interactions.

What would you have InteractionGraph.interactions return? just a flat list of Interactions?

[tomvanmele]

yes, a flat list of all interaction objects for easy access. we do the same, for example, with elements in the model...

[tomvanmele]

in my opinion this long string should be built by __str__ itself, or by some kind of private method, but not by a public API method, since it is basically a utility of __str__...

[petrasvestartas]

@chenkasirer Invoke format and push once more.

[petrasvestartas]

@tomvanmele

Could we merge and close this pull request?