feat: Subscription Service for Auto-Swap #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Gerson2102 Great job so far, Could you add tests, and also run |
|
Aight! @Abeeujah currently working on the tests. |
|
Hi @Gerson2102 can you please fix CI issue? |
|
@Abeeujah can you run the the CI again to see what happens now please? |
Gerson2102
force-pushed
the
subscription-service
branch
from
7cb3b2a to
74f1c03
Compare
|
@Gerson2102 Kindly run |
Abeeujah
requested changes
Nov 29, 2024
|
I dont know how to make the tests working from the first time that we run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Closes #2
Changes
Adding the subscription file handling all the logic related to the requirements.
Adding new types
Adding new route
Notes
I tested locally and is working. But I'm not 100% sure if this is what you guys want. Is my first time doing something like this.