Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in shallue_van_de_woestijne description #276

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Typo in shallue_van_de_woestijne description #276

merged 1 commit into from
Nov 17, 2023

Conversation

roconnor-blockstream
Copy link
Contributor

No description provided.

real-or-random
real-or-random approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c33d224

note:
During review I noticed that we save a mul by replacing

secp256k1_fe_mul(&x3d, &c, t); /* mag 1 */
secp256k1_fe_sqr(&x3d, &x3d); /* mag 1 */

with

secp256k1_fe_sqr(&x3d, &wn); /* mag 1 */

@real-or-random real-or-random merged commit eb4fb6d into BlockstreamResearch:master Nov 17, 2023
102 checks passed
@real-or-random
Copy link
Collaborator

During review I noticed that we save a mul by replacing

See #277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@real-or-random real-or-random real-or-random approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roconnor-blockstream @real-or-random