Use Publisher field for Publisher Group instead of bookshelves #70
+191
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, allow grid filtering on publisher & original publisher
andrew-polk
requested changes
Apr 7, 2020
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @hatton)
src/components/BookShelfGroup.tsx, line 99 at r1 (raw file):
us
use (if you're making changes)
src/components/PublisherGroup.tsx, line 16 at r1 (raw file):
us
use (if you're making changes)
src/connection/LibraryQueryHooks.ts, line 683 at r1 (raw file):
publisher
originalPublisher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, allow grid filtering on publisher & original publisher
This change is