Skip to content

Commit

Permalink
chore: properly clean up package.json before publish
Browse files Browse the repository at this point in the history
  • Loading branch information
andrew-polk committed Jul 2, 2024
1 parent 9e7e2fe commit 58ce4e1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 45 deletions.
10 changes: 4 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,10 @@ jobs:
- name: Run tests
run: yarn test

- name: Create clean package ready to publish
# strips out the scripts, dependencies, etc.
run: npx clean-publish --without-publish --temp-dir package

- name: Switch to package directory
run: cd package
- name: Clean up package.json
# We used to use the clean-publish package to do this, but when
# we switched to using semantic-release, we had to do it manually.
run: npm pkg delete scripts && npm pkg delete devDependencies && npm pkg delete dependencies

- name: Publish package
env:
Expand Down
13 changes: 1 addition & 12 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@
"build-dev": "shx rm -rf dist/ && webpack --config webpack.config.js",
"tslint": "tslint --project tsconfig.json",
"test": "jest",
"test-storybook": "test-storybook --url http://localhost:9009",
"//publish-clean": "strips out the scripts, dependencies, etc and then does `npm publish`",
"publish-clean": "clean-publish"
"test-storybook": "test-storybook --url http://localhost:9009"
},
"dependencies": {
"@material-ui/core": "^4.12.3",
Expand Down Expand Up @@ -71,7 +69,6 @@
"babel-jest": "^27.4.6",
"babel-loader": "^8.0.6",
"before-build-webpack": "^0.2.11",
"clean-publish": "^4.0.1",
"concurrently": "^4.1.1",
"copy-webpack-plugin": "^5.0.4",
"css-loader": "^2.1.1",
Expand Down Expand Up @@ -113,14 +110,6 @@
"dist/*.css",
"dist/*.tsv"
],
"clean-publish": {
"packageManager": "yarn",
"fields": [
"dependencies",
"scripts",
"engines"
]
},
"volta": {
"node": "16.14.0",
"yarn": "1.22.19"
Expand Down
28 changes: 1 addition & 27 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6605,16 +6605,6 @@ clean-css@^4.2.3:
dependencies:
source-map "~0.6.0"

clean-publish@^4.0.1:
version "4.0.1"
resolved "https://registry.yarnpkg.com/clean-publish/-/clean-publish-4.0.1.tgz#8492fa1ef9b5d5f8e26cbca76c849a2be14543a3"
integrity sha512-6v0bh5kQD5FDlxBgXDVNNc6KmAB7iIP/GHD91q9xsGVZT5XB9Y8TNqB7dL5u9PTZlBeLpBw+A1AseRlEEJLSWA==
dependencies:
cross-spawn "^7.0.3"
fast-glob "^3.2.11"
lilconfig "^2.0.5"
micromatch "^4.0.5"

clean-stack@^2.0.0:
version "2.2.0"
resolved "https://registry.yarnpkg.com/clean-stack/-/clean-stack-2.2.0.tgz#ee8472dbb129e727b31e8a10a427dee9dfe4008b"
Expand Down Expand Up @@ -8816,17 +8806,6 @@ fast-glob@^2.2.6:
merge2 "^1.2.3"
micromatch "^3.1.10"

fast-glob@^3.2.11:
version "3.2.11"
resolved "https://registry.yarnpkg.com/fast-glob/-/fast-glob-3.2.11.tgz#a1172ad95ceb8a16e20caa5c5e56480e5129c1d9"
integrity sha512-xrO3+1bxSo3ZVHAnqzyuewYT6aMFHRAd4Kcs92MAonjwQZLsK9d0SF1IyQ3k5PoirxTW0Oe/RqFgMQ6TcNE5Ew==
dependencies:
"@nodelib/fs.stat" "^2.0.2"
"@nodelib/fs.walk" "^1.2.3"
glob-parent "^5.1.2"
merge2 "^1.3.0"
micromatch "^4.0.4"

fast-glob@^3.2.9:
version "3.2.12"
resolved "https://registry.yarnpkg.com/fast-glob/-/fast-glob-3.2.12.tgz#7f39ec99c2e6ab030337142da9e0c18f37afae80"
Expand Down Expand Up @@ -12726,11 +12705,6 @@ libnpmversion@^3.0.7:
proc-log "^2.0.0"
semver "^7.3.7"

lilconfig@^2.0.5:
version "2.0.6"
resolved "https://registry.yarnpkg.com/lilconfig/-/lilconfig-2.0.6.tgz#32a384558bd58af3d4c6e077dd1ad1d397bc69d4"
integrity sha512-9JROoBW7pobfsx+Sq2JsASvCo6Pfo6WWoUW79HuB1BCoBXD4PLWJPqDF6fNj67pqBYTbAHkE57M1kS/+L1neOg==

lines-and-columns@^1.1.6:
version "1.2.4"
resolved "https://registry.yarnpkg.com/lines-and-columns/-/lines-and-columns-1.2.4.tgz#eca284f75d2965079309dc0ad9255abb2ebc1632"
Expand Down Expand Up @@ -13261,7 +13235,7 @@ micromatch@^3.1.10, micromatch@^3.1.4:
snapdragon "^0.8.1"
to-regex "^3.0.2"

micromatch@^4.0.2, micromatch@^4.0.5:
micromatch@^4.0.2:
version "4.0.5"
resolved "https://registry.yarnpkg.com/micromatch/-/micromatch-4.0.5.tgz#bc8999a7cbbf77cdc89f132f6e467051b49090c6"
integrity sha512-DMy+ERcEW2q8Z2Po+WNXuw3c5YaUSFjAO5GsJqfEl7UjvtIuFKO6ZrKvcItdy98dwFI2N1tg3zNIdKaQT+aNdA==
Expand Down

0 comments on commit 58ce4e1

Please sign in to comment.