Skip to content

Commit

Permalink
fix: Prevent clicks on video toggling app bar (BL-13737)
Browse files Browse the repository at this point in the history
  • Loading branch information
JohnThomson committed Sep 18, 2024
1 parent 74558fc commit ddd4a8d
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion src/bloom-player-core.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2103,7 +2103,13 @@ export class BloomPlayerCore extends React.Component<IProps, IState> {
if (
!this.state.ignorePhonyClick && // if we're dragging, that isn't a click we want to propagate
this.props.onContentClick &&
!this.activityManager.getActivityAbsorbsClicking()
!this.activityManager.getActivityAbsorbsClicking() &&
// clicks in video containers are probably aimed at the video controls.
// I tried adding another click handler to the video container with stopPropagation,
// but for some reason it didn't work.
!(e.target as HTMLElement).closest(
".bloom-videoContainer"
)
) {
this.props.onContentClick(e);
}
Expand Down

0 comments on commit ddd4a8d

Please sign in to comment.