Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bl 904 bd migrate and seed newsfeed table #6

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

razborovdb
Copy link
Contributor

Description

  1. Added to schema.sql SQL queries to migrate tables: newsfeed
  2. Added to data.sql SQL queries to seed tables: newsfeed
  3. Created class Newsfeed for table newsfeed
  4. Created interface NewsfeedRepository to access data in table newsfeed
  5. Created test classes MigrationSeedNewsfeedTest for test migration and seed
    for the table newsfeed.

Loom Video

https://www.loom.com/share/1d6dca9cc382465db29b0655e0a9257a

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have removed unnecessary comments/console logs from my code
  • I have made corresponding changes to the documentation if necessary (optional)
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings
  • No duplicate code left within changed files
  • Size of pull request kept to a minimum
  • Pull request description clearly describes changes made & motivations for said changes

Copy link
Contributor

@decagondev decagondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is another example of clean and clear code that is almost self documenting. along with a good test set and clear schema.

@ashtilawat23 ashtilawat23 merged commit 54c0845 into main Nov 7, 2022
@ashtilawat23 ashtilawat23 deleted the BL-904-bd-migrate-and-seed-newsfeed-table branch November 7, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants