Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nexus integration #major #137

Merged
merged 54 commits into from
Jun 24, 2024
Merged

Add Nexus integration #major #137

merged 54 commits into from
Jun 24, 2024

Conversation

ilkilic
Copy link
Collaborator

@ilkilic ilkilic commented May 13, 2024

The Nexus integration enables users to store and manage e-models on Nexus. This extension offers a dedicated access point, NexusAccessPoint, and a set of functions designed to create e-model-related resources. These resources are automatically linked to existing electrophysiological data, mechanisms, and morphology registered on Nexus. Additionally, this PR includes an export script that facilitates the exporting of local e-models to Nexus, as well as an example demonstrating how to run a simulation of an e-model stored on Nexus using BlueCellulab.

@ilkilic ilkilic self-assigned this May 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2024

Codecov Report

Attention: Patch coverage is 32.66069% with 901 lines in your changes missing coverage. Please review.

Project coverage is 53.45%. Comparing base (8d5b0ab) to head (341b3bf).
Report is 22 commits behind head on main.

Files Patch % Lines
bluepyemodel/access_point/nexus.py 19.44% 468 Missing ⚠️
bluepyemodel/access_point/forge_access_point.py 28.70% 380 Missing ⚠️
bluepyemodel/export_emodel/export_emodel.py 4.16% 46 Missing ⚠️
bluepyemodel/emodel_pipeline/emodel_pipeline.py 60.00% 4 Missing ⚠️
tests/unit_tests/test_nexus_access_point.py 97.70% 2 Missing ⚠️
bluepyemodel/tasks/emodel_creation/optimisation.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   60.07%   53.45%   -6.63%     
==========================================
  Files         109      122      +13     
  Lines        7838     9666    +1828     
==========================================
+ Hits         4709     5167     +458     
- Misses       3129     4499    +1370     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not comment directly on file examples/run_emodel/run_emodel.ipynb so I do it here:
"Below is a list of Nexus ID of some of the detailed canonical emodel" -> I don't see any though?

examples/local2nexus/README.md Outdated Show resolved Hide resolved
examples/local2nexus/README.md Outdated Show resolved Hide resolved
examples/local2nexus/README.md Outdated Show resolved Hide resolved
examples/local2nexus/README.md Outdated Show resolved Hide resolved
examples/local2nexus/README.md Outdated Show resolved Hide resolved
examples/run_emodel/run_emodel.py Outdated Show resolved Hide resolved
@ilkilic
Copy link
Collaborator Author

ilkilic commented Jun 19, 2024

I could not comment directly on file examples/run_emodel/run_emodel.ipynb so I do it here: "Below is a list of Nexus ID of some of the detailed canonical emodel" -> I don't see any though?

good catch. I will remove that sentence or do you want to list some Nexus IDs?

@AurelienJaquier
Copy link
Collaborator

I could not comment directly on file examples/run_emodel/run_emodel.ipynb so I do it here: "Below is a list of Nexus ID of some of the detailed canonical emodel" -> I don't see any though?

good catch. I will remove that sentence or do you want to list some Nexus IDs?

It is ok for me to just remove the sentence

@ilkilic
Copy link
Collaborator Author

ilkilic commented Jun 20, 2024

I haven't read everything yet. I think we could keep the EModel_pipeline_nexus, and just use it make it a child of EModel_pipeline with data_access_point="nexus". That way people that were using it just have to change the import, and don't have to re-write their pipeline call.

Good idea, I have reintroduced it and placed it in emodel_pipeline.py

@ilkilic
Copy link
Collaborator Author

ilkilic commented Jun 20, 2024

@darshanmandge thanks for the suggestions. Perhaps these could be addressed in a separate PR since we want to merge this as soon as possible

Copy link
Collaborator

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, Sure. Thanks. You can address the suggestions in a separate PR

@AurelienJaquier
Copy link
Collaborator

@ilkilic before merging could you make sure that this has all the latest commits from bluepyemodelnexus? I see that e.g. examples/memodel/memodel.py is missing

@ilkilic
Copy link
Collaborator Author

ilkilic commented Jun 20, 2024

yes, all the latest commits should be there, I was planning to add the examples at a later point since some are still not ready to be open-sourced, but I guess I can already add the memodel example in this PR, let me add it

@ilkilic
Copy link
Collaborator Author

ilkilic commented Jun 24, 2024

Tested and I confirm that everything works. This is ready to merge...

Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last small changes required before merging ;)

examples/memodel/memodel.py Outdated Show resolved Hide resolved
examples/memodel/memodel.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot!

@ilkilic ilkilic merged commit 8f9e098 into main Jun 24, 2024
6 checks passed
@ilkilic ilkilic deleted the nexus branch June 24, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants