-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nexus integration #major #137
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
- Coverage 60.07% 53.45% -6.63%
==========================================
Files 109 122 +13
Lines 7838 9666 +1828
==========================================
+ Hits 4709 5167 +458
- Misses 3129 4499 +1370 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not comment directly on file examples/run_emodel/run_emodel.ipynb so I do it here:
"Below is a list of Nexus ID of some of the detailed canonical emodel" -> I don't see any though?
good catch. I will remove that sentence or do you want to list some Nexus IDs? |
It is ok for me to just remove the sentence |
Good idea, I have reintroduced it and placed it in |
@darshanmandge thanks for the suggestions. Perhaps these could be addressed in a separate PR since we want to merge this as soon as possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, Sure. Thanks. You can address the suggestions in a separate PR
@ilkilic before merging could you make sure that this has all the latest commits from |
yes, all the latest commits should be there, I was planning to add the examples at a later point since some are still not ready to be open-sourced, but I guess I can already add the memodel example in this PR, let me add it |
Tested and I confirm that everything works. This is ready to merge... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last small changes required before merging ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks a lot!
The Nexus integration enables users to store and manage e-models on Nexus. This extension offers a dedicated access point,
NexusAccessPoint
, and a set of functions designed to create e-model-related resources. These resources are automatically linked to existing electrophysiological data, mechanisms, and morphology registered on Nexus. Additionally, this PR includes an export script that facilitates the exporting of local e-models to Nexus, as well as an example demonstrating how to run a simulation of an e-model stored on Nexus using BlueCellulab.