-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow non-specific currents not starting with 'i' #145
Conversation
Change-Id: I5bbc6a583b1afec2d23a0c86fb464808958b5467
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
- Coverage 60.07% 53.44% -6.64%
==========================================
Files 109 122 +13
Lines 7838 9665 +1827
==========================================
+ Hits 4709 5165 +456
- Misses 3129 4500 +1371 ☔ View full report in Codecov by Sentry. |
@ilkilic/ @AurelienJaquier could you test this PR to see if currentscape plots are correct for one of the models? |
Change-Id: I724132c47f063b536a732f2a8866f88a3e1edc3c
Change-Id: I64a6695e273f228e8cee28f12af967e60e026fb5
… fix-ion-current
Change-Id: I91765433d901453d6544dc66af8112f3d4b72ebf
…andards Change-Id: I1cd73f3b77297b5815015dfbe1b6598c45529e20
Change-Id: Ib2e97450eb5ea5415d025f2deaf75e50c7e18a8e
Tested with nexus access point for resource using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks
reason: we can have non-specific currents starting with another letter, e.g.
'lk'
.Also only return unique currents and ionic concentrations in
get_ion_currents_concentrations()
.Use latest nexus metadata standards to get currents and ionic concentration data in nexus access_point.
Use cross_bucket=False in the fetch of available_mechanisms. Reason: some mechanisms in other projects do not conform to latest metadata standards and having cross_bucket=True can lead to resources from other projects with missing metadata to be picked over the actual resource from our project with full metadata.