Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frequency in FI curve and add global parameters #170

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Conversation

AurelienJaquier
Copy link
Collaborator

No description provided.

Jaquier Aurélien Tristan added 2 commits September 18, 2024 09:27
Change-Id: I03867e69b2d6ee3bff527ee43106dad0038fb41c
Change-Id: If9d23eea7816bc3dbc4ddb3d2161cbec58451139
@AurelienJaquier AurelienJaquier self-assigned this Sep 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.49%. Comparing base (8d5b0ab) to head (dcad6de).
Report is 96 commits behind head on main.

Files with missing lines Patch % Lines
bluepyemodel/emodel_pipeline/plotting.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   60.07%   52.49%   -7.59%     
==========================================
  Files         109      124      +15     
  Lines        7838    10418    +2580     
==========================================
+ Hits         4709     5469     +760     
- Misses       3129     4949    +1820     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Change-Id: Ib63f81c5ceaec3d944f1bddb7115a1fb8560e75f
Copy link
Collaborator

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked for one of the e-models. FI-curve works now.

@AurelienJaquier AurelienJaquier merged commit 75c439a into main Sep 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants