-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused 'test' entries in the example pyr.json #51
Conversation
ilkilic
commented
Sep 18, 2023
•
edited
Loading
edited
- (removed) Highlight feature labels in red when scores exceed the SCORE_THRESHOLD of 5.0.
- Throw an error if the checkpoints directory is empty.
- Remove unused 'test' entry from pyr.json.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 61.68% 61.64% -0.04%
==========================================
Files 93 93
Lines 6235 6239 +4
==========================================
Hits 3846 3846
- Misses 2389 2393 +4
☔ View full report in Codecov by Sentry. |
After consulting with @darshanmandge , it was noted that highlighting the label has the potential to clutter the plot. Alternatively, we could consider implementing this as an optional setting, or keep only the scores in red as it was originally. |
How does changing the color have the potential to clutter the plot? |
sorry, apparently we have a lot of optimizations with bad fittings scores. I believe that marking all the labels in red might be excessive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
when merging, give a name to the merge commit that is not misleading, since we ended up not highlighting labels