Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fork iterators homogeneous #1025

Closed
wants to merge 2 commits into from
Closed

Make fork iterators homogeneous #1025

wants to merge 2 commits into from

Conversation

eleftherioszisis
Copy link
Contributor

No description provided.

@mgeplf
Copy link
Collaborator

mgeplf commented Apr 27, 2022

only the tests/test_mixed.py tests fail, does that mean this is backwards compat?

@eleftherioszisis
Copy link
Contributor Author

only the tests/test_mixed.py tests fail, does that mean this is backwards compat?

Nope. The test_mixed.py tests both subtree enabled and disabled feature calculation.

However, it is true that for a morphology with homogeneous neurites, there would be no backward break because of these iterators. Only in the case of artifacts, e.g. a mistyped section, the homogeneous fork iterator would skip the forking point.

@adrien-berchet adrien-berchet added this to the v4 milestone Feb 22, 2023
@eleftherioszisis
Copy link
Contributor Author

Closing for now. We may revisit it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
version 4.0
Projects
None yet
Milestone
v4
Development

Successfully merging this pull request may close these issues.
3 participants
@eleftherioszisis @mgeplf @adrien-berchet