Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __version__ attribute #1117

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Add __version__ attribute #1117

merged 2 commits into from
Apr 23, 2024

Conversation

adrien-berchet
Copy link
Member

No description provided.

@@ -68,3 +70,5 @@
AXON = NeuriteType.axon
SOMA = NeuriteType.soma
ANY_NEURITE = NeuriteType.all

__version__ = version(__package__)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add that at the top before the other imports:
https://peps.python.org/pep-0008/#module-level-dunder-names

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

❗ No coverage uploaded for pull request base (v4@90224b1). Click here to learn what that means.
The diff coverage is 100.00%.

Additional details and impacted files
@@          Coverage Diff           @@
##             v4     #1117   +/-   ##
======================================
  Coverage      ?   100.00%           
======================================
  Files         ?        35           
  Lines         ?      2625           
  Branches      ?         0           
======================================
  Hits          ?      2625           
  Misses        ?         0           
  Partials      ?         0           

@adrien-berchet adrien-berchet merged commit 985a4dd into v4 Apr 23, 2024
5 checks passed
@adrien-berchet adrien-berchet deleted the add__version__ branch April 23, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants