-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correcting coverage calculations #310
Conversation
removed unnecessary if check in coverage yaml switch to codecov-action@v3 add .codecov.yml with branch coverage gcov add --branches flag to gcovr branch detection: no codecov.yml gcovr treat pratials as hits gcov to give txt output delete .codecov.yml mention txt format gcovr try json format for gcovr gcovr output -> xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
The old "test (3.7) Expected — Waiting for status to be reported" is blocking us from merging. |
@wvangeit the old test check is blocking it seems to be due to the branch protection rules https://github.com/orgs/community/discussions/26698#discussioncomment-3252954. Could you update them please? If you'll merge could you also squash the commits this time? I created lots of revert commits while testing, they will look confusing in the git log I think. |
ok finally found how to remove the check. @anilbey it's good to be merged now ;) |
Great, thanks @AurelienJaquier |
Description
As reported in #306, the python coverage reposting of efel was wrong. It was only detecting the test modules' coverage.
This PR corrects the coverage calculations for Python and also starts measuring coverage for C++. Efel is 58.7% C++ and
39.4% Python.
The whole list of changes include:
Current status of coverage
We have ~%96 Python coverage and ~%41 C++ branch coverage.
Python
C++
branches: 41.4% (6394 out of 15450)