Feat: Add all_burst_number #367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilbey
suggested changes
Feb 6, 2024
efel/pyfeatures/pyfeatures.py
Outdated
| @@ -140,6 +141,45 @@ def strict_burst_number() -> np.ndarray: | |||
| return np.array([burst_mean_freq.size]) | |||
|
|
|||
|
|
|||
| def all_burst_number(): | |||
There was a problem hiding this comment.
Wouldn't it be more descriptive to call it something like count_burst_events_by_isi_clustering?
efel/pyfeatures/pyfeatures.py
Outdated
| peak_times = peak_times[(peak_times > stim_start) & (peak_times < stim_end)] | ||
| isis = np.diff(peak_times) | ||
|
|
||
| from sklearn.cluster import KMeans |
There was a problem hiding this comment.
Could you put it at the top of the file and then add scikit-learn>=X.Y.Z to setup.py, where X.Y.Z is the version you tested?
efel/pyfeatures/pyfeatures.py
Outdated
| @@ -140,6 +141,46 @@ def strict_burst_number() -> np.ndarray: | |||
| return np.array([burst_mean_freq.size]) | |||
|
|
|||
|
|
|||
| def all_burst_number(raise_warnings: bool = False) -> np.ndarray: | |||
There was a problem hiding this comment.
Wouldn't it be more descriptive to name it something like count_burst_events_by_isi_clustering?
|
I'm closing this, we can use #391 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See docstring for details, WIP for work with @PolinaL
I'll add test/doc/changelog once stable
Checklist: