Ap phaseslope range

[AurelienJaquier]

Description

Please include a summary of the change.
By default the change will increment the patch version.
To increment major or minor changes add #major or #minor to the PR description.

Checklist:

• Unit tests are added to cover the changes (skip if not applicable).
• The changes are mentioned in the documentation (skip if not applicable).
• CHANGELOG file is updated (skip if not applicable).

[ilkilic]

I think we can also change the argument to int here then:

eFEL/efel/cppcore/SpikeShape.cpp

Line 2282 in 7a69d06

double range) {

and then we won't need the type conversion

eFEL/efel/cppcore/SpikeShape.cpp

Line 2295 in 7a69d06

range_min_index = apbegin_index - int(range);

eFEL/efel/cppcore/SpikeShape.cpp

Line 2296 in 7a69d06

range_max_index = apbegin_index + int(range);

[AurelienJaquier]

I think we can also change the argument to int here then:

eFEL/efel/cppcore/SpikeShape.cpp

Line 2282 in 7a69d06

double range) {

and then we won't need the type conversion

eFEL/efel/cppcore/SpikeShape.cpp

Line 2295 in 7a69d06

range_min_index = apbegin_index - int(range);

eFEL/efel/cppcore/SpikeShape.cpp

Line 2296 in 7a69d06

range_max_index = apbegin_index + int(range);

Indeed. Fixed in latest commit.

[ilkilic]

Thanks! Looks good to me

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.24%. Comparing base (2cddd26) to head (329110d).
Report is 21 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
+ Coverage   91.73%   92.24%   +0.50%     
==========================================
  Files          36       37       +1     
  Lines        6278     7116     +838     
  Branches     2033     2283     +250     
==========================================
+ Hits         5759     6564     +805     
- Misses        266      271       +5     
- Partials      253      281      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.