[BBPBGLIB-1125] GH forkflow for building a wheel #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
matz-e
reviewed
Feb 7, 2024
## Context After deprecating BlueConfig files, we no longer support legacy node format, MVD3 or NCS. Therefore, this PR removes the corresponding node loaders. ## Scope In `cell_reader.py`: keeping only `load_sonata` and removing the other readers. In `metype.py`: removing `Cell_V5`. ## Testing Adapt the current unit tests to use SONATA nodes. ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [x] Unit/Scientific test added * [x] Updated Readme, in-code, developer documentation
## Context Addresses BBPBGLIB-1124. Removes code related to hoc targets, as well as the need of using a hoc TargetManager. ## Scope Few functions were implemented in the python Targetmanager in order to remove the hoc version: getMETypes(), getPointList() and location_to_point() ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [ ] Unit/Scientific test added * [ ] Updated Readme, in-code, developer documentation
## Context After removing BlueConfig, we only support SONATA edges files loaded via `libsonata` API. This PR removes the synpase loaders that were used to support non-SONATA files. ## Scope Remove `SynapseReader.mod`. In `synapse_reader.py`, remove class `SynReaderNRN` which was used to load non-SONATA .h5 files via `HDF5Reader`. ## Testing Remove the test for `SynReaderNRN` ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [ ] Unit/Scientific test added * [x] Updated Readme, in-code, developer documentation
…th errors (#120) ## Context In the simulation config, synapse_configure contains HOC code. Neurodamus should fail fast when there is an error in configuration, instead of passing it forward. ## Scope Error check is added to connection.py ## Testing TBD ## Review * [X] PR description is complete * [X] Coding style (imports, function length, New functions, classes or files) are good * [x] Unit/Scientific test added * [N/A] Updated Readme, in-code, developer documentation
## Context After the deprecation of BlueConfig files, out.dat is not generated anymore. Remove the SpikeWriter mod file and the code that was handling the old out.dat spike file. ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [ ] Unit/Scientific test added * [ ] Updated Readme, in-code, developer documentation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
WeinaJi
reviewed
Mar 1, 2024
This comment has been minimized.
This comment has been minimized.
This reverts commit c95917b.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
looks good to me. @jorblancoa , can you also have a look ? |
|
looks good to me also! |
jorblancoa
approved these changes
Mar 11, 2024
WeinaJi
approved these changes
Mar 11, 2024
|
Logfiles from GitLab pipeline #199613 (:white_check_mark:) have been uploaded here! Status and direct links: |
WeinaJi
added a commit
that referenced
this pull request
Oct 14, 2024
## Context Build and upload a PyPI wheel ## Scope New Github actions workflow ## Testing Should see if it works with Github actions ## Review * [X] PR description is complete * [X] Coding style (imports, function length, New functions, classes or files) are good * [N/A] Unit/Scientific test added * [N/A] Updated Readme, in-code, developer documentation --------- Co-authored-by: WeinaJi <weina.ji@epfl.ch> Co-authored-by: Jorge Blanco Alonso <41900536+jorblancoa@users.noreply.github.com> Co-authored-by: Erik Heeren <erik.heeren@epfl.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Build and upload a PyPI wheel
Scope
New Github actions workflow
Testing
Should see if it works with Github actions
Review