Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CvodeBlock and CvodeVisitor #1467

Merged
merged 55 commits into from
Oct 28, 2024
Merged

Add CvodeBlock and CvodeVisitor #1467

merged 55 commits into from
Oct 28, 2024

Conversation

JCGoran
Copy link
Contributor

@JCGoran JCGoran commented Sep 24, 2024 •
edited
Loading

Part 1 of #1399.
Adds the CVODE block since NMODL solves the DERIVATIVE block in-place, and we lose information about it. Also adds a visitors which actually replaces statements of the form x' = f(x) into Dx = f(x).

@JCGoran JCGoran changed the title Add DerivativeOriginalFunctionBlock and DerivativeVisitor Add DerivativeOriginalFunctionBlock and DerivativeOriginalVisitor Sep 24, 2024
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Sep 24, 2024
References for 'BlueBrain/nmodl#1467'.
4bcb324
@JCGoran JCGoran marked this pull request as ready for review September 24, 2024 18:04
1uc
1uc reviewed Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments:

  • The DerivativeOriginalBlock is advertised as an unmodified copy. However, it's immediately during the process it's being modified.
  • There's no code demonstrating how this works, i.e. no tests or anything similar.

src/visitors/derivative_original_visitor.hpp Outdated Show resolved Hide resolved
src/visitors/derivative_original_visitor.hpp Outdated Show resolved Hide resolved
src/visitors/derivative_original_visitor.cpp Outdated Show resolved Hide resolved
src/visitors/derivative_original_visitor.cpp Outdated Show resolved Hide resolved
src/language/codegen.yaml Outdated Show resolved Hide resolved
src/language/codegen.yaml Outdated Show resolved Hide resolved
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Sep 25, 2024
References for 'BlueBrain/nmodl#1467'.
0cd60c8
@JCGoran
Remove unused stuff
1125fdf 
`DERIVATIVE` blocks can't have array variables in NOCMODL by default, so
let's go with that.
@JCGoran
Update block description
0267fbd
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Sep 25, 2024
References for 'BlueBrain/nmodl#1467'.
2e2abdb
@JCGoran JCGoran mentioned this pull request Sep 25, 2024
Closed
@JCGoran JCGoran changed the title Add DerivativeOriginalFunctionBlock and DerivativeOriginalVisitor Add CvodeBlock and CvodeVisitor Sep 27, 2024
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Sep 27, 2024
References for 'BlueBrain/nmodl#1467'.
830a0e4
1uc
1uc reviewed Sep 30, 2024
View reviewed changes
src/visitors/derivative_original_visitor.hpp Outdated Show resolved Hide resolved
src/visitors/derivative_original_visitor.hpp Outdated Show resolved Hide resolved
src/visitors/derivative_original_visitor.hpp Outdated Show resolved Hide resolved
test/unit/visitor/derivative_original.cpp Outdated Show resolved Hide resolved
test/unit/visitor/derivative_original.cpp Outdated Show resolved Hide resolved
src/visitors/derivative_original_visitor.cpp Outdated Show resolved Hide resolved
src/visitors/derivative_original_visitor.cpp Outdated Show resolved Hide resolved
@JCGoran JCGoran marked this pull request as draft September 30, 2024 08:08
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Oct 14, 2024
References for 'BlueBrain/nmodl#1467'.
f83a5ca
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Oct 14, 2024
References for 'BlueBrain/nmodl#1467'.
96595bb
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Oct 15, 2024
References for 'BlueBrain/nmodl#1467'.
8956a26
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Oct 15, 2024
References for 'BlueBrain/nmodl#1467'.
fc32d22
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Oct 16, 2024
References for 'BlueBrain/nmodl#1467'.
869757c
1uc
1uc reviewed Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good, a couple of last minor comments.

src/visitors/cvode_visitor.cpp Outdated Show resolved Hide resolved
src/visitors/cvode_visitor.cpp Outdated Show resolved Hide resolved
src/visitors/cvode_visitor.cpp Outdated Show resolved Hide resolved
src/visitors/cvode_visitor.cpp Outdated Show resolved Hide resolved
src/visitors/cvode_visitor.cpp Outdated Show resolved Hide resolved
1uc
1uc reviewed Oct 24, 2024
View reviewed changes
src/visitors/cvode_visitor.cpp Outdated Show resolved Hide resolved
src/visitors/cvode_visitor.cpp Outdated Show resolved Hide resolved
src/visitors/cvode_visitor.cpp Outdated Show resolved Hide resolved
@JCGoran JCGoran merged commit 6b6a630 into master Oct 28, 2024
12 checks passed
@JCGoran JCGoran deleted the jelic/cvode_visitors branch October 28, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1uc 1uc 1uc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JCGoran @1uc