SOLVE a PROCEDURE. #1521
Merged
SOLVE a PROCEDURE. #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Oct 15, 2024
|
It should be checking the return code of the procedure. However, that requires some slightly lengthy changes, which I'd like to postpone. This allows us to compile mod files found in the nrn tests and should be correct for any correct runs. |
|
See #1526 for followup work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From inspecting NOCMODL generated code it seems that:
where
procis some procedure, simply calls the procedure and checks if it returned an error code. This PR only implements the call part and leaves the checking part for the future.