Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set mask dtype to np.uint32 by default without using ENV variables? #272

Open
matt-sd-watson opened this issue Nov 20, 2024 · 3 comments
Open

Comments

@matt-sd-watson
Copy link
Contributor

Previous discussion of how to specify unsigned 32-byte integer dtype for masks here: #207

We have collaborators that are struggling with enforcing this env command when running steinbock either through an HPC cluster or through basic CLI. Additionally, for increasingly large ROIs, as well as updated 5 micron tissues modes for IMC, we are observing more instances where there are many more cells that can be accommodated in 16 byte integers (~65000).

Perhaps the default mask output dtype could be changed to unsigned 32 byte integer? I understand that for past compatibility with ImageJ, unsigned 32 byte integers were not used, but with new imaging software was well as our own visualisation application, support 32 byte masks has become the standard (and is the default is our IMC viewer for the reasons stated above).

@jwindhager
Copy link
Contributor

I endorse (requires a MINOR version bump at least)

@xwxdazhong
Copy link

I endorse

1 similar comment
@ttj131
Copy link

ttj131 commented Dec 1, 2024

I endorse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants