refactor #11: Abstracted depopulateObject

src/api/apiUtils.js

@@ -14,3 +14,22 @@ export function handleError(error) {
 	console.error("API call failed. " + error);
 	throw error;
 }
+
+export function depopulateObject(obj, ...populatedProperties) {
+	const depopulatedObject = obj;
+
+	populatedProperties.forEach(property => {
+		let targetProp = obj[property];
+		if (!Array.isArray(targetProp)) {
+			depopulatedObject[property] = targetProp._id;
+		} else {
+			let depopulated = [];
+			depopulatedObject[property].forEach(item => {
+				depopulated.push(item._id);
+			});
+			depopulatedObject[property] = depopulated;
+		}
+		return;
+	});
+	return depopulatedObject;
+}

src/api/cardApi.js

@@ -1,15 +1,13 @@
-import { handleResponse, handleError } from "./apiUtils";
+import {
+	depopulateMongooseObject,
+	handleResponse,
+	handleError
+} from "./apiUtils";
 import { bearerHeaders } from "../tools/auth";
 const baseUrl = process.env.REACT_APP_API_URL + "/api/cards/";
 
 export function depopulateCard(card) {
-	card.owner = card.owner._id;
-	let members = [];
-	card.members.forEach(member => {
-		members.push(member._id);
-	});
-	card.members = members;
-	return card;
+	return depopulateMongooseObject(card, "owner", "members");
 }
 
 export function getCards() {

src/api/cardApi.test.js

@@ -32,9 +32,10 @@ it("should clean up referenced members", function() {
 		createdDate: "2019-08-31T16:39:28.780Z",
 		modifiedDate: "2019-08-31T16:39:28.780Z"
 	};
-
-	expect(depopulateCard(card).members).toEqual([
+	const depopulatedCard = depopulateCard(card);
+	expect(depopulatedCard.members).toEqual([
 		"5d42104a7979bd071c129606",
 		"5d42104a7979bd071c129609"
 	]);
+	expect(depopulatedCard.owner).toEqual("5d42e5d5e1e3d731df26010a");
 });