Hero Section Mobile Styled #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first fork and pull request from an open-source project so if there are issues, my apologies.
The hero section had issues on my mobile phone, the Pixel 6. I went to the custom.sass file to make some updates up to 768 pixels. The hero section shouldn't conflict with other classes.
Home Page: Before Images
Getting Started: Before Image
As you can see, the section breaks. I propose this change.
After Image
I have reviewed and looked at the hero changes to the other pages. Here is the Getting Started page
I would hope to believe there's no need to maintain these changes and as long as the code is solid.