Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Star battle #879

Closed
wants to merge 13 commits into from
Closed

Star battle #879

wants to merge 13 commits into from

Conversation

offline171
Copy link
Collaborator

Description

Closes #(issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

offline171 added 13 commits July 30, 2024 14:33
@offline171
Fixed Empty Adjacent Test
2108874 
Fixed Empty Adjacent Test (one of those one line deletion bug fixes) and got rid of print statements and comments blocking useful lines of code
@offline171
Adding border functionality
e5d7ded 
Starter code for borders
@offline171
Border locations
1838eb7 
Added primitive code to outline where borders would be placed
@offline171
Start on code to actually draw the borders
e0156a5 
commented out rough draft on how element view draws borders. Don't need an image for them likely, just use basic drawRect function, and make sure to distinguish if it's vertical or horizontal if necessary
@offline171
Made dedicated border classes
1f2e980 
Made dedicated border classes to help define them for drawing
@offline171
Revamped border detection and drawing
217f4e8 
Changed how borders were counted and drawn to be more in line with skyscrapers
@offline171
Borders added
eb49c27 
Borders added, slipped in-between cells equally, colored red so as to not be confused with the black empty squares
@offline171
Update log4j2.properties
115c1f4 
Attempting to solve merge issue
@offline171
Update EmptyAdjacentDirectRule.java
f5e932b 
Undoing changes to fix merge conflict
@offline171
Update EmptyAdjacentDirectRuleTest.java
eaccb9a 
More undoing
@offline171
Update EmptyAdjacentDirectRuleTest.java
301dc3d 
More
@offline171
Test difference
d7e80f6 
All the puzzle files in origin star battle branch are missing. I'm deleting a temp file to see if github will spot the difference.
@offline171
Test Difference add
19fcc47 
Same but add instead of remove
@offline171 offline171 closed this Jan 21, 2025
@offline171
Copy link
Collaborator Author

Wrong branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@offline171