SDK-2061 request payload refactor #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # BranchSDK/BranchOpenRequest.m
# Conflicts: # Branch-TestBed/Branch-TestBed.xcodeproj/project.pbxproj
…ents. Also separate IDFA check to make testing easier.
| @@ -817,23 +803,6 @@ - (void) setInvokeRegisterApp:(BOOL)invoke { | |||
| } | |||
| } | |||
|
|
|||
| - (BOOL) useEUServers { | |||
There was a problem hiding this comment.
@echo-branch Is this property not persistent?
There was a problem hiding this comment.
I was thinking it would be set on app launch, either in code or config file.
# Conflicts: # Branch-TestBed/Branch-SDK-Tests/BranchInstallRequestTests.m # Branch-TestBed/Branch-SDK-Tests/BranchOpenRequestTests.m # Branch-TestBed/Branch-TestBed.xcodeproj/project.pbxproj # BranchSDK/BranchInstallRequest.m # BranchSDK/BranchOpenRequest.m
… need to follow up.
echo-branch
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1295 +/- ##
==========================================
- Coverage 51.73% 50.48% -1.26%
==========================================
Files 74 68 -6
Lines 10663 10106 -557
Branches 4121 3889 -232
==========================================
- Hits 5517 5102 -415
+ Misses 4894 4758 -136
+ Partials 252 246 -6
|
NidhiDixit09
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
SDK-2061 Request payload refactor
Summary
Refactored server request generation out of BNCServerInterface to simplify data collection rules and enforcement.
Motivation
Existing data collection is split across several classes, this made it challenging to enforce data collection rules based on different privacy settings.
Type Of Change
Testing Instructions
See testing notion doc and follow up JIRA tickets for details.
cc @BranchMetrics/saas-sdk-devs for visibility.