the SDK state clear happened with the old close call #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r on background to match previous behavior
NidhiDixit09
approved these changes
Nov 28, 2023
|
The fix looks good to me. However, it looks like this branch is using the old testbed branch key so the requests are failing. I'll push a commit to fix it since i just added it locally anyways. |
nsingh-branch
approved these changes
Nov 28, 2023
|
Code looks good to me. I can see opens when app is foregrounded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
INTENG-19489 fix organic warm open
Summary
SDK init status was cleared by the close call, with it's removal we need to clear it elsewhere to maintain previous behavior.
Motivation
Restore previous behavior around organic opens.
Type Of Change
Testing Instructions
Repeat with this change, and step 4 will have a network call to init.
cc @BranchMetrics/saas-sdk-devs for visibility.