Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK-1711 fix crash on iOS 12 when using the pre-built xcframework #1325

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

echo-branch
Copy link
Contributor

Reference

SDK-1711 fix crash on iOS 12 when using the pre-built xcframework

Summary

Copies fix for linker issue from the Xamarin hotfix

Motivation

Xamarin uses the binary framework and is severely impacted by this crash.

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)

Testing Instructions

Integrate a test app using the pre-built xcframework
Run app on iOS 12, notice crash.

When using the version built with this change, the app should not crash.

cc @BranchMetrics/saas-sdk-devs for visibility.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b7ab30a) 53.77% compared to head (b955e8c) 53.77%.
Report is 6 commits behind head on master.

Files Patch % Lines
BranchSDK/Branch.m 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
- Coverage   53.77%   53.77%   -0.01%     
==========================================
  Files          68       68              
  Lines       10086    10087       +1     
  Branches     3886     3886              
==========================================
  Hits         5424     5424              
- Misses       4409     4410       +1     
  Partials      253      253              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@NidhiDixit09 NidhiDixit09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS 12 for dynamic frameworks as well as for static libs. It looks all good to me. For static ones user needs to specify -weak_framework LinkPresentation linker flags in build settings of the app.

@echo-branch echo-branch merged commit 0102d94 into master Dec 2, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants