Add safety fallback when we are unable to unarchive requests #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1368 +/- ##
==========================================
+ Coverage 51.03% 51.18% +0.15%
==========================================
Files 66 66
Lines 10126 10151 +25
Branches 3714 3728 +14
==========================================
+ Hits 5168 5196 +28
+ Misses 4700 4695 -5
- Partials 258 260 +2 ☔ View full report in Codecov by Sentry. |
# Conflicts: # Branch-TestBed/Branch-TestBed.xcodeproj/project.pbxproj # Sources/BranchSDK/BNCServerRequestQueue.m
gdeluna-branch
approved these changes
Apr 2, 2024
nsingh-branch
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
SDK-2263
Summary
On failure to unarchive our request queue, we do not remove the incorrect requests. This leads to repeated failures to unarchive.
Believe this issue can occur when upgrading to version 3.3 from some older versions.
Motivation
Safer fallback when we fail to unarchive.
Type Of Change
Testing Instructions
We do not have internal repro. However we can mimic a failure to unarchive, will demonstrate during team working meeting.
cc @BranchMetrics/saas-sdk-devs for visibility.