-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-2458] Implement Consumer Protection Preferences #1407
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsingh-branch
changed the title
[WIP] [SDK-2458] Implement Consumer Protection Preferences
[SDK-2458] Implement Consumer Protection Preferences
Jun 25, 2024
NidhiDixit09
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
SDK-2458 -- [iOS] Implement Consumer Protection Preferences
Summary
Added a new method for setting the consumer protection preference,
setConsumerProtectionPreference
. This value can be set and changed at any time, but persists across sessions. This change also deprecated thesetTrackingDisabled()
method since setting the preference toBranchConsumerProtectionPreferenceTrackingDisabled
will perform the same logic.Motivation
To give clients more control over what end user information is tracked or used for attribution.
Type Of Change
Testing Instructions
Call
[[Branch getInstance] setConsumerProtectionPreference:BranchConsumerProtectionPreferenceAnalyticsOnly];
, or any other preference, at any point in the app and then observe the respective field appearing in the following requests, like"protection_preference" : 2,
cc @BranchMetrics/saas-sdk-devs for visibility.