Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2470] Created branchVPNBlockingError method #1414

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

nsingh-branch
Copy link
Contributor

@nsingh-branch nsingh-branch commented Jul 23, 2024

Reference

SDK-2470 -- Create new method for detecting VPN Ad blocker

Summary

Added branchVPNBlockingError to detect when a device is connected to a VPN and requests are failing with a specific error code.

Error Code Docs: https://developer.apple.com/documentation/cfnetwork/cfnetworkerrors/kcfurlerrorcannotconnecttohost?language=objc
CFNetworkingCopySystemProxySettings Docs:
https://developer.apple.com/documentation/cfnetwork/cfnetworkcopysystemproxysettings()

Motivation

We want to provide more information in error logs to help clients with debugging regarding Branch.

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing Instructions

Enable a VPN Ad Blocker and observe if requests are failing and returning the proper error logs.

cc @BranchMetrics/saas-sdk-devs for visibility.

@nsingh-branch nsingh-branch merged commit 8386b56 into master Jul 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants