[SDK-2475] Fix for BNCURLFilter's regex being set as external_intent_uri

[nsingh-branch]

Reference

SDK-2475 -- Fix bug where URL filter regex is being sent as external_intent_uri

Summary

We have been seeing requests where the external_intent_uri is one of the values in our URL filter pattern likes, like "^fb\\d+:((?!campaign_ids).)*$". This appears to be due to a typo in the handleDeepLink function where if the link which opened the app matches the pattern, we set it as the externalIntentURI and referringURL. Changing this to set these fields to the actual URI seems to fix this issue and sends the proper requests.

Branch.m

   pattern = [self.urlFilter patternMatchingURL:url];
    if (!pattern) {
        pattern = [self.userURLFilter patternMatchingURL:url];
    }
    if (pattern) {
        self.preferenceHelper.dropURLOpen = YES;

        //Problematic Lines
        self.preferenceHelper.externalIntentURI = pattern;
        self.preferenceHelper.referringURL = pattern;
        //

        [self initUserSessionAndCallCallback:YES sceneIdentifier:sceneIdentifier urlString:nil];
        return NO;
    }

Motivation

To fix the bug and correctly set the external_intent_uri in requests.

Type Of Change

• Bug fix (non-breaking change which fixes an issue)

Testing Instructions

Add any URI scheme that matches the regex to your app and then open your app via that link. Observe the request's external_intent_uri before and after the change.

Possible URI schemes:
Facebook: fb1234://some_path
LinkedIn: li5678://profile
Pinterest: pdk91011://board
TwitterKit: twitterkit-xyz123://timeline
Google OAuth: com.googleusercontent.apps.1234567890-abcdef:/oauth
Sensitive Info, Non-HTTP/HTTPS: customscheme://login?oauth_token=abcdef123456
Sensitive Info, HTTP/HTTPS: https://example.com/resource?access_token=abcdef123456

cc @BranchMetrics/saas-sdk-devs for visibility.

[NidhiDixit09]

Looks good to me.