SDK-2506 Removed Events Caching #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsingh-branch
approved these changes
Oct 23, 2024
| static NSString * const BRANCH_QUEUE_FILE = @"BNCServerRequestQueue"; | ||
| static NSTimeInterval const BATCH_WRITE_TIMEOUT = 3.0; | ||
|
|
||
|
|
||
| static inline uint64_t BNCNanoSecondsFromTimeInterval(NSTimeInterval interval) { |
There was a problem hiding this comment.
Can this be removed as well? It seems like its not used anywhere else either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
SDK-2506 -- Remove Events Caching
https://branch.atlassian.net/browse/SDK-2506
Summary
This PR removes on disk caching of events as well as related test cases.
NOTE : Encoding Functions (initWithCoder, encodeWithCoder, supportsSecureCoding) are not removed from request classes. They might be used by app developers if they serialize/archive these objects.
Testing Instructions
Prior behavior: SDK maintained a copy of Server Request Queue on disk. On every cold launch, SDK reads request objects from this disk queue and add then tries to send them again.
After: SDK will not read and write any events to disk.
Steps to test -
cc @BranchMetrics/saas-sdk-devs for visibility.