-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup project to support multiple versions of polars #72
Conversation
Investigating failing tests. When running locally I had old dependencies so I did not catch failure before MR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
+ Coverage 94.61% 94.65% +0.03%
==========================================
Files 13 13
Lines 1431 1441 +10
==========================================
+ Hits 1354 1364 +10
Misses 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good to me, see my comments. Did you do a search on the codebase to make sure we're not missing other .drop()
or .join()
statements that need updating?
Will double check one more time and clean up code based on comments. Thank you sir for the feedback. |
1fd6c1e
to
592c8f3
Compare
All comments have been addressed. Not sure why it's still showing one request.
Very cool your matrix testing 😎 |
This MR simply allows any codebase which uses pyoframe to specify which version of polars they wish to use. In our case we are trying to migrate to version 1.12, but currently use 0.20. One thing to consider is that I don't allow the polars dependency to increase beyond the minor version 1.12. I've seen in their release logs that they historically have introduced deprecated API calls between minor bumps which is curious. Therefore I think with each update we'll need to refer to the polars update guide and determine if we can push the upper bound on the polars version.