Skip to content

[cli] Move output command state out of CliContext #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Breakthrough merged 3 commits into from
Oct 6, 2024
Merged

[cli] Move output command state out of CliContext #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a99aed1
[cli] Move output command state out of CliContext
Breakthrough Sep 20, 2024
ded3708
[cli] Centralize preconditions in CliContext
Breakthrough Sep 28, 2024
1154c01
[cli] Simplify parsing of default values
Breakthrough Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions scenedetect/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@

def main():
"""PySceneDetect command-line interface (CLI) entry point."""
cli_ctx = CliContext()
context = CliContext()
try:
# Process command line arguments and subcommands to initialize the context.
scenedetect.main(obj=cli_ctx) # Parse CLI arguments with registered callbacks.
scenedetect.main(obj=context) # Parse CLI arguments with registered callbacks.
except SystemExit as exit:
help_command = any(arg in sys.argv for arg in ["-h", "--help"])
if help_command or exit.code != 0:
Expand All @@ -38,12 +38,12 @@ def main():
# no progress bars get created, we instead create a fake context manager. This is done here
# to avoid needing a separate context manager at each point a progress bar is created.
log_redirect = (
FakeTqdmLoggingRedirect() if cli_ctx.quiet_mode else logging_redirect_tqdm(loggers=[logger])
FakeTqdmLoggingRedirect() if context.quiet_mode else logging_redirect_tqdm(loggers=[logger])
)

with log_redirect:
try:
run_scenedetect(cli_ctx)
run_scenedetect(context)
except KeyboardInterrupt:
logger.info("Stopped.")
if __debug__:
Expand All @@ -52,7 +52,7 @@ def main():
if __debug__:
raise
else:
logger.critical("Unhandled exception:", exc_info=ex)
logger.critical("ERROR: Unhandled exception:", exc_info=ex)
raise SystemExit(1) from None


Expand Down
Loading