Skip to content

Parsing timecodes of form MM:SS[.nnn] #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Breakthrough merged 2 commits into from
Oct 6, 2024
Merged

Parsing timecodes of form MM:SS[.nnn] #433

Breakthrough merged 2 commits into from
Oct 6, 2024

Conversation

@wjs018
Copy link
Collaborator

@wjs018 wjs018 commented Oct 6, 2024

Addresses #432 to handle parsing timecodes of format MM:SS[.nnn].

@wjs018 wjs018 requested a review from Breakthrough October 6, 2024 04:15
@wjs018 wjs018 linked an issue Oct 6, 2024 that may be closed by this pull request
Confusing error message with incorrect timecode input #432
Closed
@Breakthrough Breakthrough added this to the 0.6.5 milestone Oct 6, 2024
Breakthrough
Breakthrough approved these changes Oct 6, 2024
View reviewed changes
Copy link
Owner

@Breakthrough Breakthrough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Breakthrough Breakthrough merged commit db952d4 into Breakthrough:main Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Breakthrough Breakthrough Breakthrough approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.6.5

Development

Successfully merging this pull request may close these issues.

Confusing error message with incorrect timecode input

2 participants

@wjs018 @Breakthrough