Have fire check all neighbor node for interact#16
Open
asl97 wants to merge 1 commit intoBremaweb:masterfrom
Open
Have fire check all neighbor node for interact#16asl97 wants to merge 1 commit intoBremaweb:masterfrom
asl97 wants to merge 1 commit intoBremaweb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
how is checking just corner0 and corner1 enough to pass to the default function?
this look like it was make this way just to kill all the fire but if that is the case, then there is no need to check for all those corners, just return a
trueotherwise, it should be properly done by checking all 26 (plus 1 which is the fire itself since excluding it is really just micro optimization) next to the fire to see if it is allow to interact with it.