Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the implementation of noise for ALLEGRO v3 to the old fccrun script #35

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zwu0922
Copy link

@zwu0922 zwu0922 commented Aug 19, 2024

With the new barrel geometry tool matching the segmentation of ALLEGRO v3, electronic noise can be switched on for ALLEGRO ECAL in run_thetamodulemerged.py.

Nightly version:
source /cvmfs/sw-nightlies.hsf.org/key4hep/setup.sh -r 2024-07-31

  1. Please merge this PR only after Add tools for the implmentation of noise for ALLEGRO v3 HEP-FCC/k4RecCalorimeter#107 is merged into k4RecCalorimeter.
  2. The noise filter is not ready yet. So, the size of the output file expands by a lot (around 550 MB for 10 events).
  3. Sometimes the energy of CorrectedCaloTopoClusters can be -NAN due to the negative input with the noise switch on. Do we expect this to happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant